BUG: Fix boolean value of NA is ambiguous in iloc assignment #62696
+31
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able integer Series
…able integer Series
…able integer Series
…able integer Series
…able integer Series
|
@MarcoGorelli please review these changes when you get chance. |
|
@jbrockmendel please review these changes when you get chance. |
| values = np.asarray(original, dtype=dtype) | ||
| else: | ||
| values = np.asarray(original, dtype="object") | ||
| if not (pd.isna(values[idx]) or pd.isna(original[idx])): |
There was a problem hiding this comment.
can you check this without pd.isna? we try to avoid importing pd in files that are "high up" in the dependency hierarchy
| else: | ||
| dtype = dtype.numpy_dtype | ||
|
|
||
| if is_integer_dtype(dtype) and values.dtype.kind == "f" and len(values) > 0: |
There was a problem hiding this comment.
i think the fundamental issue is that when we get here we are implicitly assuming that values is an ndarray, while in this case it is a Series. If we called extract_array at the top of this function, then we would go through the if isinstance(values, cls): branch on L159, right?
|
I apologize for not replying earlier, I was in the hospital. I’ll continue working on this in the next 2–3 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please let me know if my approach or fix needs any improvements . I’m open to feedback and happy to make changes based on suggestions.
Thank you !